On Mon, Oct 1, 2018 at 2:16 PM Bertrand Delacretaz <[email protected]> wrote:
> Hi, > > On Thu, Sep 20, 2018 at 4:17 PM Jan Lahoda <[email protected]> wrote: > > ...I have a question about code under the MIT license that is modified... > > Do you mean that the code will be modified after being forked to the > NetBeans repository, or that the license has been modified? > Code under MIT forked and modified. > > If that's the former I think the "Treatment of Third-Party Works" > section at https://www.apache.org/legal/src-headers.html applies and > as per https://www.apache.org/legal/resolved.html it's fine to > redistribute MIT licensed code. > > IMO it's best to put such code in a specific folder ("forks" or > "third-party" maybe) to point people to its origin as needed, and it > might require a mention in the NOTICE file - or not, that file should > stay minimal. > While technically this will be a fork, I don't think it makes much sense to use "forked" or "third-party" (see below). The current proposed directory name is simply "vscode". I'll add a README pointing to the originals. > > Note that in general it's much preferred to make improvements to the > original code rather than fork it, if that's possible - I suppose you > know that ;-) > In this case, what I forked is a sample extension for VS Code, and adjusted it for NetBeans. I doubt pushing the NetBeans changes back to the sample would be accepted. So, while technically this is a fork of that sample code, there's no real "upstream". Thanks, Jan > > If it's the latter and it's the MIT license that's been > modified...that's much more complicated. > > -Bertrand > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
