[
https://issues.apache.org/jira/browse/NUTCH-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762287#comment-13762287
]
Sebastian Nagel commented on NUTCH-1638:
----------------------------------------
Hi [~ascheffe], this code should be correct. If copyMap does not contain key
mapCopyKey(key) returns key (same object!) . If, on the opposite, copyMap
contains key, its value is returned. Then (key != key) and the field is copied
(added under a second name).
But you're right: "someone was trying to be clever" (he is). It took me some
time to understand the code. At a first glance, it seems dubious. A short
comment would be nice.
> SolrWriter Bad String comparision
> ---------------------------------
>
> Key: NUTCH-1638
> URL: https://issues.apache.org/jira/browse/NUTCH-1638
> Project: Nutch
> Issue Type: Bug
> Components: indexer
> Affects Versions: 1.7, 2.2.1
> Reporter: Aaron Scheffel
> Priority: Minor
> Labels: patch
> Attachments: NUTCH-1638.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> In version 2.2.1 and 1.7
> Class org.apache.nutch.indexer.solr.SolrWriter
> Line 66
> inputDoc.addField(solrMapping.mapKey(e.getKey()), val2);
> String sCopy = solrMapping.mapCopyKey(e.getKey());
> if (sCopy != e.getKey()) {
> inputDoc.addField(sCopy, val2);
> }
> There is a string comparison "sCopy != e.getKey()" with a != and not an
> equals. It basically never works right. Not sure if someone was trying to
> be clever but even if those strings are the same they happen to be
> different objects. Which I'm assuming is due to how the strings are
> serialized in from the config files.
> Suggest its updated to
> String sCopy = solrMapping.mapCopyKey(e.getKey());
> if (!sCopy.equals(solrMapping.mapKey(e.getKey()))) {
> inputDoc.addField(sCopy, val2);
> }
> -Aaron
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
