[
https://issues.apache.org/jira/browse/NUTCH-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastian Nagel reopened NUTCH-1883:
------------------------------------
Assignee: Sebastian Nagel
Hi [~jnioche], you're definitely right. Thanks! "Patch for the patch":
* show a nice message for Generator:
{noformat}
...
Generator: 0 records selected for fetching, exiting ...
Generate returned 1 (no new segments created)
Escaping loop: no more URLs to fetch now
{noformat}
* use function to call dedup
> bin/crawl: use function to run bin/nutch and check exit value
> -------------------------------------------------------------
>
> Key: NUTCH-1883
> URL: https://issues.apache.org/jira/browse/NUTCH-1883
> Project: Nutch
> Issue Type: Improvement
> Affects Versions: 1.9, 2.2.1
> Reporter: Sebastian Nagel
> Assignee: Sebastian Nagel
> Priority: Minor
> Fix For: 2.3, 1.10
>
> Attachments: NUTCH-1883-2x-v1.patch, NUTCH-1883-trunk-v1.patch
>
>
> In bin/crawl for every Nutch command the exit value is checked explicitly:
> {code}
> "$bin/nutch" ...
> RETCODE=$?
> if [ $RETCODE -ne 0 ]
> then exit $RETCODE
> fi
> {code}
> This could be simplified by calling bin/nutch from one function which does
> the check. The function could also echo the command, show an error message,
> etc. The main advantage is short and clear code. In case a special treatment
> of exit values is required (cf. NUTCH-1829) we still could call bin/nutch
> directly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
