[ 
https://issues.apache.org/jira/browse/NUTCH-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503882#comment-14503882
 ] 

Chris A. Mattmann commented on NUTCH-1934:
------------------------------------------

well my point is on this - you can keep this as a patch and spend the effort to 
take a > 1000 line Java file and keep it up to date with trunk or you can risk 
that you broke something in trunk, but make the fixes to that 1000000000x 
easier by having it committed. Your call :)

> Refactor Fetcher in trunk
> -------------------------
>
>                 Key: NUTCH-1934
>                 URL: https://issues.apache.org/jira/browse/NUTCH-1934
>             Project: Nutch
>          Issue Type: Improvement
>          Components: fetcher
>    Affects Versions: 1.10
>            Reporter: Lewis John McGibbney
>            Assignee: Lewis John McGibbney
>              Labels: memex
>             Fix For: 1.11
>
>         Attachments: NUTCH-1934-trunkv2.patch, NUTCH-1934.patch
>
>
> Put simply 
> [Fetcher|https://github.com/apache/nutch/blob/trunk/src/java/org/apache/nutch/fetcher/Fetcher.java]
>  is too big.
> This is kinda strange as the size of this file is unique (I think) from every 
> other class within Nutch. The others are reasonably well modularized and 
> split into constituent classes which make sense.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to