[
https://issues.apache.org/jira/browse/NUTCH-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15145777#comment-15145777
]
ASF GitHub Bot commented on NUTCH-2218:
---------------------------------------
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/nutch/pull/91#discussion_r52822613
--- Diff: src/java/org/apache/nutch/util/CrawlCompletionStats.java ---
@@ -61,27 +69,60 @@
private int mode = 0;
public int run(String[] args) throws Exception {
- if (args.length < 3) {
- System.err.println("Usage: CrawlCompletionStats inputDirs outDir
mode [numOfReducer]");
+ Option helpOpt = new Option("h", "help", false, "Show this message");
+ Option inDirs = OptionBuilder
+ .withArgName("inputDirs")
+ .isRequired()
+ .withDescription("Comma separated list of crawl directories")
--- End diff --
This could do with being explicit e.g. providing an example
> Switch CrawlCompletion arg parsing to Commons CLI
> -------------------------------------------------
>
> Key: NUTCH-2218
> URL: https://issues.apache.org/jira/browse/NUTCH-2218
> Project: Nutch
> Issue Type: Improvement
> Components: util
> Affects Versions: 1.11
> Reporter: Michael Joyce
> Assignee: Michael Joyce
> Priority: Minor
> Fix For: 1.12
>
>
> The current CrawlCompletion utility should be updated to use commons CLI
> instead of doing manual arg parsing and checking.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
