[
https://issues.apache.org/jira/browse/NUTCH-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastian Nagel resolved NUTCH-2620.
------------------------------------
Resolution: Fixed
Merged [PR #362|https://github.com/apache/nutch/pull/362]. Thanks, good catch,
[~drdevil]!
After the introduction of [generic
TLDs|https://en.wikipedia.org/wiki/Generic_top-level_domain] the check for max.
4 characters does harm. The longest TLD in the current [IANA TLD
list|https://data.iana.org/TLD/tlds-alpha-by-domain.txt] is 24 characters long.
> urlfilter-validator incorrectly assumes that top-level domains are not longer
> than 4 characters
> -----------------------------------------------------------------------------------------------
>
> Key: NUTCH-2620
> URL: https://issues.apache.org/jira/browse/NUTCH-2620
> Project: Nutch
> Issue Type: Bug
> Affects Versions: 1.15
> Reporter: Gareth
> Priority: Major
> Labels: easyfix
> Fix For: 1.15
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The code assumes a TLD can be max 4 in length. But this is wrong.
>
> https://github.com/apache/nutch/blob/f011b2193c24e031aafbcfa1e66fc2bcbb59098b/src/plugin/urlfilter-validator/src/java/org/apache/nutch/urlfilter/validator/UrlValidator.java#L280
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
