sebastian-nagel commented on a change in pull request #534:
URL: https://github.com/apache/nutch/pull/534#discussion_r438267053



##########
File path: src/plugin/indexer-csv/README.md
##########
@@ -39,4 +39,4 @@ escapechar | Escape character used to escape a quote 
character | "
 maxfieldlength | Max. length of a single field value in characters | 4096
 maxfieldvalues | Max. number of values of one field, useful for, e.g., the 
anchor texts field | 12
 header | Write CSV column headers | true
-outpath | Output path / directory (local filesystem path, relative to current 
working directory) | csvindexwriter
\ No newline at end of file
+outpath | Output path / directory (local filesystem path, relative to current 
working directory) | csvindexwriter

Review comment:
       Sorry, I've mixed two points mixed together:
   - the description would also need a change as it will not be a path on the 
local filesystem if running in distributed mode
   - there is also the open question how to allow two index writers writing 
output the filesystem:
     - in local mode this would require that the `outpath` points to a 
different directory
     - in distributed mode we could use `outpath` to write into distinct output 
directories or distinct subdirectories of one job-specific output directory




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to