sebastian-nagel commented on a change in pull request #537:
URL: https://github.com/apache/nutch/pull/537#discussion_r452865637
##########
File path: src/java/org/apache/nutch/protocol/RobotRulesParser.java
##########
@@ -376,13 +379,18 @@ public int run(String[] args) {
*/
private static class TestRobotRulesParser extends RobotRulesParser {
- public TestRobotRulesParser(Configuration conf) {
+ public void setConf(Configuration conf) {
// make sure that agent name is set so that setConf() does not complain,
Review comment:
Thanks. You're right the comment wasn't up-to-date. Would have been
simpler to drop the command-line overwrite of the checked agent names and rely
only on properties. But I didn't want to break the existing behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
