[
https://issues.apache.org/jira/browse/NUTCH-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17779335#comment-17779335
]
ASF GitHub Bot commented on NUTCH-2887:
---------------------------------------
lewismc commented on PR #791:
URL: https://github.com/apache/nutch/pull/791#issuecomment-1778548551
OK, I'm over the bulk of the work here.
A brief synopsis of what has been done so far...
* new junit5 jupiter dependencies added to `ivy.xml`
* All assertions migrated to new `org.junit.jupiter.api.Assertions` package
* All annotations migrated to new `org.junit.jupiter.api` package e.g.
`@Test`
* `@Before` and `@After` no longer exist; migrated to `@BeforeEach` and
`@AfterEach`
* `@Ignore` no longer exists: migrated to `@Disabled` but we should
definitely review these cases and see if we can activate them
I think we may be able to improve test execution by investigate parallel
execution but that will come in a subsequent PR
Additionally, loads of tests are failing right now due to my limited
understanding of how to migrate from Ant's legacy [junit
task](https://ant.apache.org/manual/Tasks/junit.html) to the junit5
[junitlauncher task](https://ant.apache.org/manual/Tasks/junitlauncher.html).
I think one more push and this PR should be ready for review.
> Migrate to JUnit 5 Jupiter
> --------------------------
>
> Key: NUTCH-2887
> URL: https://issues.apache.org/jira/browse/NUTCH-2887
> Project: Nutch
> Issue Type: Improvement
> Components: test
> Environment: Migrate
> Reporter: Lewis John McGibbney
> Assignee: Lewis John McGibbney
> Priority: Major
> Fix For: 1.20
>
>
> This effort is a bit of a beast. See the [JUnit migration
> tips|https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4-tips]
> for general guidance. A general grep for junit in src produces the following
> {code:bash}
> ./test/nutch-site.xml
> ./test/org/apache/nutch/tools/TestCommonCrawlDataDumper.java
> ./test/org/apache/nutch/net/TestURLNormalizers.java
> ./test/org/apache/nutch/net/protocols/TestHttpDateFormat.java
> ./test/org/apache/nutch/net/TestURLFilters.java
> ./test/org/apache/nutch/util/TestStringUtil.java
> ./test/org/apache/nutch/util/TestSuffixStringMatcher.java
> ./test/org/apache/nutch/util/TestEncodingDetector.java
> ./test/org/apache/nutch/util/TestMimeUtil.java
> ./test/org/apache/nutch/util/TestPrefixStringMatcher.java
> ./test/org/apache/nutch/util/DumpFileUtilTest.java
> ./test/org/apache/nutch/util/TestNodeWalker.java
> ./test/org/apache/nutch/util/WritableTestUtils.java
> ./test/org/apache/nutch/util/TestTableUtil.java
> ./test/org/apache/nutch/util/TestURLUtil.java
> ./test/org/apache/nutch/util/TestGZIPUtils.java
> ./test/org/apache/nutch/parse/TestParseText.java
> ./test/org/apache/nutch/parse/TestOutlinks.java
> ./test/org/apache/nutch/parse/TestParseData.java
> ./test/org/apache/nutch/parse/TestOutlinkExtractor.java
> ./test/org/apache/nutch/parse/TestParserFactory.java
> ./test/org/apache/nutch/segment/TestSegmentMerger.java
> ./test/org/apache/nutch/segment/TestSegmentMergerCrawlDatums.java
> ./test/org/apache/nutch/plugin/TestPluginSystem.java
> ./test/org/apache/nutch/fetcher/TestFetcher.java
> ./test/org/apache/nutch/protocol/TestProtocolFactory.java
> ./test/org/apache/nutch/protocol/TestContent.java
> ./test/org/apache/nutch/protocol/AbstractHttpProtocolPluginTest.java
> ./test/org/apache/nutch/crawl/TestCrawlDbFilter.java
> ./test/org/apache/nutch/crawl/TestTextProfileSignature.java
> ./test/org/apache/nutch/crawl/TestCrawlDbStates.java
> ./test/org/apache/nutch/crawl/TestGenerator.java
> ./test/org/apache/nutch/crawl/TestAdaptiveFetchSchedule.java
> ./test/org/apache/nutch/crawl/TODOTestCrawlDbStates.java
> ./test/org/apache/nutch/crawl/TestSignatureFactory.java
> ./test/org/apache/nutch/crawl/ContinuousCrawlTestUtil.java
> ./test/org/apache/nutch/crawl/TestInjector.java
> ./test/org/apache/nutch/crawl/TestLinkDbMerger.java
> ./test/org/apache/nutch/crawl/TestCrawlDbMerger.java
> ./test/org/apache/nutch/service/TestNutchServer.java
> ./test/org/apache/nutch/metadata/TestMetadata.java
> ./test/org/apache/nutch/metadata/TestSpellCheckedMetadata.java
> ./test/org/apache/nutch/indexer/TestIndexingFilters.java
> ./test/org/apache/nutch/indexer/TestIndexerMapReduce.java
> ./bin/nutch
> ./plugin/scoring-orphan/src/test/org/apache/nutch/scoring/orphan/TestOrphanScoringFilter.java
> ./plugin/index-basic/src/test/org/apache/nutch/indexer/basic/TestBasicIndexingFilter.java
> ./plugin/urlfilter-domaindenylist/build.xml
> ./plugin/urlfilter-domaindenylist/src/test/org/apache/nutch/urlfilter/domaindenylist/TestDomainDenylistURLFilter.java
> ./plugin/protocol-imaps/plugin.xml
> ./plugin/protocol-imaps/ivy.xml
> ./plugin/protocol-imaps/lib/junit-4.13.jar
> ./plugin/protocol-imaps/lib/greenmail-junit4-1.6.0.jar
> ./plugin/protocol-imaps/lib/greenmail-1.6.0.jar
> ./plugin/protocol-imaps/src/test/org/apache/nutch/protocol/imaps/TestImaps.java
> ./plugin/protocol-file/build.xml
> ./plugin/protocol-file/src/test/org/apache/nutch/protocol/file/TestProtocolFile.java
> ./plugin/urlnormalizer-regex/build.xml
> ./plugin/urlnormalizer-regex/src/test/org/apache/nutch/net/urlnormalizer/regex/TestRegexURLNormalizer.java
> ./plugin/build-plugin.xml
> ./plugin/creativecommons/src/test/org/creativecommons/nutch/TestCCParseFilter.java
> ./plugin/urlnormalizer-basic/src/test/org/apache/nutch/net/urlnormalizer/basic/TestBasicURLNormalizer.java
> ./plugin/urlnormalizer-protocol/build.xml
> ./plugin/urlnormalizer-protocol/src/test/org/apache/nutch/net/urlnormalizer/protocol/TestProtocolURLNormalizer.java
> ./plugin/urlfilter-prefix/src/test/org/apache/nutch/urlfilter/prefix/TestPrefixURLFilter.java
> ./plugin/urlfilter-suffix/src/test/org/apache/nutch/urlfilter/suffix/TestSuffixURLFilter.java
> ./plugin/index-more/src/test/org/apache/nutch/indexer/more/TestMoreIndexingFilter.java
> ./plugin/parse-ext/src/test/org/apache/nutch/parse/ext/TestExtParser.java
> ./plugin/urlnormalizer-host/build.xml
> ./plugin/urlnormalizer-host/src/test/org/apache/nutch/net/urlnormalizer/host/TestHostURLNormalizer.java
> ./plugin/protocol-httpclient/src/test/org/apache/nutch/protocol/httpclient/TestProtocolHttpClient.java
> ./plugin/urlfilter-validator/src/test/org/apache/nutch/urlfilter/validator/TestUrlValidator.java
> ./plugin/parse-tika/build.xml
> ./plugin/parse-tika/src/test/org/apache/nutch/parse/tika/TestRTFParser.java
> ./plugin/parse-tika/src/test/org/apache/nutch/parse/tika/TestDOMContentUtils.java
> ./plugin/parse-tika/src/test/org/apache/nutch/parse/tika/TestImageMetadata.java
> ./plugin/parse-tika/src/test/org/apache/nutch/parse/tika/TestRobotsMetaProcessor.java
> ./plugin/parse-tika/src/test/org/apache/nutch/parse/tika/TikaParserTest.java
> ./plugin/parse-tika/src/test/org/apache/nutch/parse/tika/TestFeedParser.java
> ./plugin/parse-tika/src/test/org/apache/nutch/parse/tika/TestEmbeddedDocuments.java
> ./plugin/parse-tika/src/test/org/apache/nutch/parse/tika/TestPdfParser.java
> ./plugin/parse-tika/src/test/org/apache/nutch/parse/tika/TestHtmlParser.java
> ./plugin/parse-tika/src/test/org/apache/nutch/parse/tika/TestXlsxParser.java
> ./plugin/parse-tika/src/test/org/apache/nutch/parse/tika/TestMSWordParser.java
> ./plugin/parse-tika/src/test/org/apache/nutch/parse/tika/TestOOParser.java
> ./plugin/mimetype-filter/build.xml
> ./plugin/mimetype-filter/src/test/org/apache/nutch/indexer/filter/MimeTypeIndexingFilterTest.java
> ./plugin/urlnormalizer-pass/src/test/org/apache/nutch/net/urlnormalizer/pass/TestPassURLNormalizer.java
> ./plugin/any23/build.xml
> ./plugin/any23/src/test/org/apache/nutch/any23/TestAny23ParseFilter.java
> ./plugin/any23/src/test/org/apache/nutch/any23/TestAny23IndexingFilter.java
> ./plugin/protocol-okhttp/src/test/org/apache/nutch/protocol/okhttp/TestBadServerResponses.java
> ./plugin/protocol-okhttp/src/test/org/apache/nutch/protocol/okhttp/TestProtocolOkHttp.java
> ./plugin/urlfilter-ignoreexempt/build.xml
> ./plugin/urlfilter-fast/build.xml
> ./plugin/urlfilter-fast/src/test/org/apache/nutch/urlfilter/fast/TestFastURLFilter.java
> ./plugin/index-jexl-filter/src/test/org/apache/nutch/indexer/jexl/TestJexlIndexingFilter.java
> ./plugin/urlfilter-regex/build.xml
> ./plugin/urlfilter-regex/src/test/org/apache/nutch/urlfilter/regex/TestRegexURLFilter.java
> ./plugin/lib-regex-filter/src/test/org/apache/nutch/urlfilter/api/RegexURLFilterBaseTest.java
> ./plugin/headings/src/test/org/apache/nutch/parse/headings/TestHeadingsParseFilter.java
> ./plugin/protocol-http/src/test/org/apache/nutch/protocol/http/TestBadServerResponses.java
> ./plugin/protocol-http/src/test/org/apache/nutch/protocol/http/TestProtocolHttp.java
> ./plugin/parse-swf/build.xml
> ./plugin/parse-swf/src/test/org/apache/nutch/parse/swf/TestSWFParser.java
> ./plugin/urlfilter-automaton/build.xml
> ./plugin/urlfilter-automaton/src/test/org/apache/nutch/urlfilter/automaton/TestAutomatonURLFilter.java
> ./plugin/parsefilter-regex/build.xml
> ./plugin/parsefilter-regex/src/test/org/apache/nutch/parsefilter/regex/TestRegexParseFilter.java
> ./plugin/feed/build.xml
> ./plugin/feed/src/test/org/apache/nutch/parse/feed/TestFeedParser.java
> ./plugin/index-anchor/src/test/org/apache/nutch/indexer/anchor/TestAnchorIndexingFilter.java
> ./plugin/urlfilter-domain/build.xml
> ./plugin/urlfilter-domain/src/test/org/apache/nutch/urlfilter/domain/TestDomainURLFilter.java
> ./plugin/language-identifier/src/test/org/apache/nutch/analysis/lang/TestHTMLLanguageParser.java
> ./plugin/parse-html/src/test/org/apache/nutch/parse/html/TestDOMContentUtils.java
> ./plugin/parse-html/src/test/org/apache/nutch/parse/html/TestRobotsMetaProcessor.java
> ./plugin/parse-html/src/test/org/apache/nutch/parse/html/TestHtmlParser.java
> ./plugin/index-static/src/test/org/apache/nutch/indexer/staticfield/TestStaticFieldIndexerTest.java
> ./plugin/parse-js/build.xml
> ./plugin/parse-js/src/test/org/apache/nutch/parse/js/TestJSParseFilter.java
> ./plugin/index-replace/build.xml
> ./plugin/index-replace/src/test/org/apache/nutch/indexer/replace/TestIndexReplace.java
> ./plugin/parse-metatags/build.xml
> ./plugin/parse-metatags/src/test/org/apache/nutch/parse/metatags/TestMetatagParser.java
> ./plugin/urlnormalizer-slash/build.xml
> ./plugin/urlnormalizer-slash/src/test/org/apache/nutch/net/urlnormalizer/slash/TestSlashURLNormalizer.java
> ./plugin/indexer-csv/src/test/org/apache/nutch/indexwriter/csv/TestCSVIndexWriter.java
> ./plugin/urlnormalizer-ajax/src/test/org/apache/nutch/net/urlnormalizer/ajax/TestAjaxURLNormalizer.java
> ./plugin/scoring-metadata/src/test/org/apache/nutch/scoring/metadata/TestMetadataScoringFilter.java
> ./plugin/lib-http/src/test/org/apache/nutch/protocol/http/api/TestRobotRulesParser.java
> ./plugin/subcollection/src/test/org/apache/nutch/collection/TestSubcollection.java
> ./plugin/urlnormalizer-querystring/src/test/org/apache/nutch/net/urlnormalizer/querystring/TestQuerystringURLNormalizer.java
> ./plugin/parse-zip/build.xml
> ./plugin/parse-zip/src/test/org/apache/nutch/parse/zip/TestZipParser.java
> ./plugin/index-links/src/test/org/apache/nutch/indexer/links/TestLinksIndexingFilter.java
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
