[
https://issues.apache.org/jira/browse/NUTCH-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830964#comment-17830964
]
ASF GitHub Bot commented on NUTCH-3032:
---------------------------------------
lewismc commented on code in PR #810:
URL: https://github.com/apache/nutch/pull/810#discussion_r1539390873
##########
src/plugin/index-arbitrary/ivy.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" ?>
+
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
Review Comment:
Please remove whitespace.
##########
src/plugin/index-arbitrary/src/test/org/apache/nutch/indexer/arbitrary/Multiplier.java:
##########
@@ -0,0 +1,31 @@
+package org.apache.nutch.indexer.arbitrary;
Review Comment:
Please add ALv2 license header.
##########
build.xml:
##########
@@ -44,7 +44,7 @@
<property name="spotbugs.home"
value="${ivy.dir}/spotbugs-${spotbugs.version}" />
<property name="spotbugs.jar" value="${spotbugs.home}/lib/spotbugs-ant.jar"
/>
- <property name="apache-rat.version" value="0.16.1" />
+ <property name="apache-rat.version" value="0.15" />
Review Comment:
Please sync with `master` branch. This regression is tangential to
NUTCH-3032. Thanks
##########
src/plugin/index-arbitrary/src/test/org/apache/nutch/indexer/arbitrary/Echo.java:
##########
@@ -0,0 +1,24 @@
+package org.apache.nutch.indexer.arbitrary;
Review Comment:
Please add ALv2 license header.
##########
src/plugin/index-arbitrary/ivy.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" ?>
+
Review Comment:
Please remove whitespace.
##########
src/plugin/index-arbitrary/build.xml:
##########
@@ -0,0 +1,6 @@
+<?xml version="1.0"?>
Review Comment:
Please add ALv2 license header.
##########
src/plugin/index-arbitrary/src/java/org/apache/nutch/indexer/arbitrary/ArbitraryIndexingFilter.java:
##########
@@ -0,0 +1,266 @@
+package org.apache.nutch.indexer.arbitrary;
Review Comment:
Please add ALv2 license header.
> Indexing plugin as an adapter for end user's own POJO instances
> ---------------------------------------------------------------
>
> Key: NUTCH-3032
> URL: https://issues.apache.org/jira/browse/NUTCH-3032
> Project: Nutch
> Issue Type: Improvement
> Components: indexer
> Reporter: Joe Gilvary
> Priority: Major
> Labels: indexing
> Attachments: NUTCH-3032.patch
>
>
> It could be helpful to let end users manipulate information at indexing time
> with their own code without the need for writing their own indexing plugin. I
> mentioned this on the dev mailing list
> (https://www.mail-archive.com/[email protected]/msg31190.html) with some
> description of my work in progress.
> One potential use is to address some of the same concerns that NUTCH-585
> discusses regarding an alternative approach to picking and choosing which
> content to index, but this approach would allow making index time decisions,
> rather than setting the configuration for all content at the start of the
> indexing run.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
