[
https://issues.apache.org/jira/browse/NUTCH-3043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840892#comment-17840892
]
ASF GitHub Bot commented on NUTCH-3043:
---------------------------------------
lewismc commented on code in PR #814:
URL: https://github.com/apache/nutch/pull/814#discussion_r1579883313
##########
src/java/org/apache/nutch/crawl/Generator.java:
##########
@@ -253,10 +256,7 @@ public void map(Text key, CrawlDatum value, Context
context)
try {
sort = scfilters.generatorSortValue(key, crawlDatum, sort);
} catch (ScoringFilterException sfe) {
- if (LOG.isWarnEnabled()) {
- LOG.warn(
- "Couldn't filter generatorSortValue for " + key + ": " + sfe);
- }
+ LOG.warn("Couldn't filter generatorSortValue for " + key + ": " + sfe);
Review Comment:
Please use parameterized logging.
```
LOG.warn("Couldn't filter generatorSortValue for {}: {}”, key, sfe);
```
> Generator: count URLs rejected by URL filters
> ---------------------------------------------
>
> Key: NUTCH-3043
> URL: https://issues.apache.org/jira/browse/NUTCH-3043
> Project: Nutch
> Issue Type: Improvement
> Components: generator
> Affects Versions: 1.20
> Reporter: Sebastian Nagel
> Assignee: Sebastian Nagel
> Priority: Minor
> Fix For: 1.21
>
>
> Generator already counts URLs rejected by the (re)fetch scheduler, by fetch
> interval or status. It should also count the number of URLs rejected by URL
> filters.
> See also [Generator
> metrics|https://cwiki.apache.org/confluence/display/NUTCH/Metrics#Metrics-Generator].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
