lewismc opened a new pull request, #862:
URL: https://github.com/apache/nutch/pull/862

   # Phase 2 of [NUTCH-2887](https://issues.apache.org/jira/browse/NUTCH-2887)
   
   This PR is scoped only to migrate `core` tests to JUnit 5. All `plugins` 
still run on < JUnit 5. This is intended to make the PR easier to interpret and 
review. 
   
   # Comments
   
   1. The following JUnit 3 test cases existed and were first migrated to Unit 
4 before being upgraded to JUnit 5.
   * `TestParseSegment`
   * `TestMimeUtil`
   * `TestAdaptiveFetchSchedule`
   * `ContinuousCrawlTestUtil`
   
   1. In some places Hamcrest utility methods were used to improve the 
readability of JUnit 5 assertions. This is minor and no additional dependency 
has been introduced. I used the Hamcrest 1.3.0 transitive dependency in the 
`test` scope.
   
   # Next steps
   
   The next PR will focus on migrating all `plugins` tests to JUnit 5.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to