Hi Chris,
I realize the Solr implementation does not follow the style of the
other implementations... the reason is that the Solr implementation is more
like a framework where users can supply their own implementation of critical
interfaces such as ProductSerializer and ProductIdGenerator to customize the
content of their metadata catalogs. I thought this would be clearer if each
class and interface had its own dedicated file, but if you want we can
certainly try to merge all classes/interfaces in a single file. Let me know and
I can help with the refactoring.
thanks, Luca
On Sep 1, 2013, at 2:48 PM, Mattmann, Chris A (398J) wrote:
> Hey Luca,
>
> I noticed that the SolrCatalog is in package
> o.a.oodt.cas.filemgr.catalog.solr
> instead of o.a.oodt.cas.filemgr.catalog, matching all other catalog
> implementations.
> I realize this is because you added specific classes to support the Solr
> Catalog
> and put them in that package as well. I think these classes should be
> dispersed
> either to util packages in the File Manager, or in some other support
> structure
> (e.g., as private internal classes to the SolrCatalog or
> SolrCatalogFactory) so
> as to keep consistent with the rest of the components. I'll make this
> change in
> the next few weeks (and file a JIRA issue) should there be no objections.
>
> Thanks!
>
> Cheers,
> Chris
>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Chris Mattmann, Ph.D.
> Senior Computer Scientist
> NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA
> Office: 171-266B, Mailstop: 171-246
> Email: [email protected]
> WWW: http://sunset.usc.edu/~mattmann/
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> Adjunct Assistant Professor, Computer Science Department
> University of Southern California, Los Angeles, CA 90089 USA
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
>
>
>
