steveloughran commented on PR #968:
URL: https://github.com/apache/parquet-mr/pull/968#issuecomment-1153923501
bq. perhaps check if the ByteBufferReadable interface is implemented in the
stream?
The requirement for the `hasCapability("in:readbytebuffer")` to return true
postdates the API; there's no way to be confident that if the probe returns
false (or hasPathCapability() isn't available) that the method *isn't actually
there*
see #951 for a design which will trust a `true` response, falling back to
looking at the wrapped stream. Note that as it calls getWrapped() it is calling
methods tagged LimitedPrivate. it should really do that...at the very least
hadoop needs a PR saying "we need to do this because..." and that tag can be
changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
