[
https://issues.apache.org/jira/browse/PARQUET-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555821#comment-17555821
]
ASF GitHub Bot commented on PARQUET-2158:
-----------------------------------------
sunchao commented on code in PR #976:
URL: https://github.com/apache/parquet-mr/pull/976#discussion_r900689594
##########
parquet-thrift/src/main/java/org/apache/parquet/thrift/projection/deprecated/PathGlobPattern.java:
##########
@@ -20,8 +20,8 @@
import org.apache.hadoop.fs.GlobPattern;
-import java.util.regex.Pattern;
-import java.util.regex.PatternSyntaxException;
+import com.google.re2j.Pattern;
Review Comment:
I think this may not work for projects like Spark who are using Hadoop
shaded client, since the `GlobPattern.compiled` is relocated to
`org.apache.hadoop.shaded.com.google.re2j.Pattern`.
It might be easier to just remove the class as it has been marked as
deprecated since Parquet 1.8.0, 2015. It is also not used anywhere in the
project.
> Upgrade Hadoop dependency to version 3.2.0
> ------------------------------------------
>
> Key: PARQUET-2158
> URL: https://issues.apache.org/jira/browse/PARQUET-2158
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
> Affects Versions: 1.13.0
> Reporter: Steve Loughran
> Priority: Major
>
> Parquet still builds against Hadoop 2.10. This is very out of date and does
> not work with java 11, let alone later releases.
> Upgrading the dependency to Hadoop 3.2.0 makes the release compatible with
> java 11, and lines up with active work on HADOOP-18287, _Provide a shim
> library for modern FS APIs_
> This will significantly speed up access to columnar data, especially in
> cloud stores.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
