theosib-amazon commented on code in PR #960:
URL: https://github.com/apache/parquet-mr/pull/960#discussion_r965074182
##########
parquet-common/src/main/java/org/apache/parquet/bytes/ByteBufferInputStream.java:
##########
@@ -138,6 +134,18 @@ public int read(byte[] b, int off, int len) throws
IOException {
return delegate.read(b, off, len);
}
+ public int read(byte[] b) throws IOException {
+ return read(b, 0, b.length);
+ }
+
+ public void readFully(byte b[]) throws IOException {
+ readFully(b, 0, b.length);
+ }
+
+ public void readFully(byte b[], int off, int len) throws IOException {
Review Comment:
This is what the method signatures for DataInputStream.readFully look like.
I also have a whole bunch of other performance improvements I want to
contribute
(https://docs.google.com/document/d/1fBGpF_LgtfaeHnPD5CFEIpA2Ga_lTITmFdFIcO9Af-g/edit?usp=sharing),
and I think this might get used in some of that code.
I'm very soon going to publish an open preview of all of my proposed changes
to a branch of my own fork, so we'll be able to check this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
