abaranec commented on PR #993: URL: https://github.com/apache/parquet-mr/pull/993#issuecomment-1337501132
@shangxinli Sorry it took so long to do this. I resolved the conflicts. The changes all essentially moved into NonBlockedCompressor, I also incorporated the two changes you suggested. One other thing worth discussing, For the first alloc, I'm just using the requested size as the initial. It occurs to me that it might be better to use a little more memory to guarantee that we start with, and continue with an 8-byte aligned buffer size. Maybe starting at 16 or 32 bytes. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
