amousavigourabi commented on code in PR #1141:
URL: https://github.com/apache/parquet-mr/pull/1141#discussion_r1335212974
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/util/ConfigurationUtil.java:
##########
@@ -41,4 +49,18 @@ public static Class<?> getClassFromConfig(Configuration
configuration, String co
}
}
+ public static Configuration createHadoopConfiguration(ParquetConfiguration
conf) {
+ if (conf == null) {
+ return new Configuration();
+ }
+ if (conf instanceof HadoopParquetConfiguration) {
+ return ((HadoopParquetConfiguration) conf).getConfiguration();
+ }
+ Configuration configuration = new Configuration();
Review Comment:
When using a HadoopParquetConfiguration, the user did not yet decouple from
Hadoop as it is just a wrapper for Configuration. When the user wants to
decouple from Hadoop, they can implement their own ParquetConfiguration, which
does not rely on Hadoop's Configuration (or a simple implementation is added
afterwards, this PR was getting a bit large for that already). There is still
some code right now, mainly around the codecs which _needs_ a Hadoop
Configuration. It is therefore important that while we're still removing these
last references to Hadoop, we can get such an instance from a
ParquetConfiguration, in order not to break anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
