ConeyLiu commented on code in PR #1169:
URL: https://github.com/apache/parquet-mr/pull/1169#discussion_r1357998012
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -784,13 +830,38 @@ public void writeDataPageV2(int rowCount, int nullCount,
int valueCount,
currentChunkFirstDataPage = beforeHeader;
}
- metadataConverter.writeDataPageV2Header(
- uncompressedSize, compressedSize,
- valueCount, nullCount, rowCount,
- dataEncoding,
- rlByteLength,
- dlByteLength,
- out);
+ if (pageWriteChecksumEnabled) {
Review Comment:
Add the CRC for the v2 page as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
