[
https://issues.apache.org/jira/browse/PARQUET-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774838#comment-17774838
]
ASF GitHub Bot commented on PARQUET-2363:
-----------------------------------------
ConeyLiu commented on code in PR #1169:
URL: https://github.com/apache/parquet-mr/pull/1169#discussion_r1357998012
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileWriter.java:
##########
@@ -784,13 +830,38 @@ public void writeDataPageV2(int rowCount, int nullCount,
int valueCount,
currentChunkFirstDataPage = beforeHeader;
}
- metadataConverter.writeDataPageV2Header(
- uncompressedSize, compressedSize,
- valueCount, nullCount, rowCount,
- dataEncoding,
- rlByteLength,
- dlByteLength,
- out);
+ if (pageWriteChecksumEnabled) {
Review Comment:
Add the CRC for the v2 page as well.
> ParquetRewriter should encrypt the V2 page header
> -------------------------------------------------
>
> Key: PARQUET-2363
> URL: https://issues.apache.org/jira/browse/PARQUET-2363
> Project: Parquet
> Issue Type: Bug
> Reporter: Xianyang Liu
> Priority: Major
>
> The V2 page header should be encrypted as well when doing the file rewriting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
