[
https://issues.apache.org/jira/browse/PARQUET-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774955#comment-17774955
]
ASF GitHub Bot commented on PARQUET-2347:
-----------------------------------------
ConeyLiu commented on code in PR #1141:
URL: https://github.com/apache/parquet-mr/pull/1141#discussion_r1358412633
##########
parquet-thrift/src/main/java/org/apache/parquet/thrift/ThriftRecordConverter.java:
##########
@@ -855,6 +857,18 @@ public ThriftRecordConverter(ThriftReader<T> thriftReader,
String name, MessageT
* @param conf a Configuration
*/
public ThriftRecordConverter(ThriftReader<T> thriftReader, String name,
MessageType requestedParquetSchema, ThriftType.StructType thriftType,
Configuration conf) {
+ this(thriftReader, name, requestedParquetSchema, thriftType, new
HadoopParquetConfiguration(conf));
+ }
+
+ /**
+ *
Review Comment:
blank line
> Add interface layer between Parquet and Hadoop Configuration
> ------------------------------------------------------------
>
> Key: PARQUET-2347
> URL: https://issues.apache.org/jira/browse/PARQUET-2347
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-mr
> Reporter: Atour Mousavi Gourabi
> Priority: Minor
>
> Parquet relies heavily on a few Hadoop classes, such as its Configuration
> class, which is used throughout Parquet's reading and writing logic. If we
> include our own interface for this, this could potentially allow users to use
> Parquet's readers and writers without the Hadoop dependency later on.
> In order to preserve backward compatibility and avoid breaking downstream
> projects, the constructors and methods using Hadoop's constructor should be
> preserved for the time being, though I would favour deprecation in the near
> future.
> This is part of an effort that has been [discussed on the dev mailing
> list|https://lists.apache.org/thread/4wl0l3d9dkpx4w69jx3rwnjk034dtqr8].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
