tustvold commented on PR #196: URL: https://github.com/apache/parquet-format/pull/196#issuecomment-1803642293
Just coming back to this as it has come up a bit downstream, the approach described in https://github.com/apache/parquet-format/pull/196#issuecomment-1625537697 makes a lot of sense to me. Would it help move this forward if I were to raise a separate PR proposing it? > parquet-mr can efficiently implement this sort order Provided Java provides some mechanism to interpret a float as an integer, it is just a case of some bit operations - https://doc.rust-lang.org/src/core/num/f64.rs.html#1336 > Total ordering is nice if the goal is to order the data > If the goal is to filter the data then I think any consideration of NaN/null/infinity is meaningless Why would filter predicates not also need a well-defined order? FWIW arrow-rs uses total order for **all** floating point comparison. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
