On Fri 18 Jul 2008, Philip M. Gollucci wrote:
> Torsten Foertsch wrote:
> > Please review.
>
> +        /* use the same error message as perl core's read() */
> +        Perl_croak(aTHX_ "Negative length");
> It possible someone is regexing $@ against the previous string. Do
> you really need to change the message ?

I doubt it but of course not.

> +    /* modperl_request_read can return only >=0. So it's save to do
> this. */
> +    /* if total==0 we need to set the buffer length in case it is
> larger */
>
>
> s/save/safe/

thanks

> By any chance have you tried mod_apreq2 perl glue on top of this
> patch ?

Current SVN passed all tests. So, I committed that stuff.

Torsten

--
Need professional mod_perl support?
Just hire me: [EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to