On Mon, Nov 16, 2009 at 8:25 AM, Fred Moyer <f...@redhotpenguin.com> wrote:
> On Mon, Nov 16, 2009 at 8:07 AM, Adam Prime <adam.pr...@utoronto.ca> wrote:
>> Any comments?
>
> Looks pretty safe. +1
That being said, I think this line:
+ ($major > 2 || ($major == 2 && $minor >= 6))) {
is better written as
(($major > 2) or (($major == 2) && ($minor >= 6))) {
I can't remember the style guide off the top of my head, I have it
plugged into my mod_perl perltidy instance.
>
>>
>> Petr Sumbera wrote:
>>>
>>> Fred Moyer wrote:
>>>>
>>>> On Wed, Nov 11, 2009 at 7:56 PM, Adam Prime <adam.pr...@utoronto.ca>
>>>> wrote:
>>>>>
>>>>> Petr Sumbera wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> can someone please reevaluate and commit attached patch? I would love
>>>>>> to
>>>>>> see
>>>>>> it in mod_perl 2.0.5 and 1.32 when they are released..
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Petr
>>>>>>
>>>>>> http://old.nabble.com/file/p26284847/solaris.diff solaris.diff
>>>>>
>>>>> If no one objects in the next few day or so i'll commit this (finally)
>>>>
>>>> Can you post the patch inline to this email so everyone can review it?
>>>
>>> Resending (this time directly).
>>>
>>> Thanks,
>>>
>>> Petr
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
>>> For additional commands, e-mail: dev-h...@perl.apache.org
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
>> For additional commands, e-mail: dev-h...@perl.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org
