On 05/09/2012 09:40 AM, Jan Kaluža wrote:
Right, those patches only hardcodes it for httpd-2.4. The next step
should be to probably put #ifdefs around remote_ip. Other things should
be done by source_scan script I believe.
I've splitted the patch into separate patches. This is against
mod_perl-2.0.6. With those patches, mod_perl compiles against httpd-2.2
and also against httpd-2.4. It's based on the Stefan's work.
http://jkaluza.fedorapeople.org/mod_perl/
I would favor the compatibility layer approach personally. I have some
code on CPAN that uses remote_ip, so I don't really want to go change
that to support 2.4 just yet.
If you find a way how to do it, tell me :). As I said, I think 90% of
httpd modules uses remote_ip/remote_addr in the meaning of
useragent_ip/useragent_addr.
So, there's currently used conn_rec->remote_ip and new
request_rec->useragent_ip. I can't imagine how would you write some
layer to map current conn_rec->remote_ip to request_rec->remote_ip,
since there's no way how to get particular request_rec from conn_rec. I
just think it can't be done transparently and there will be need to
change the modules anyway...
Regards,
Jan Kaluza
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org
Regards,
Jan Kaluza
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@perl.apache.org
For additional commands, e-mail: dev-h...@perl.apache.org
