[ 
https://issues.apache.org/jira/browse/QPID-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676600#action_12676600
 ] 

Danushka Menikkumbura commented on QPID-1673:
---------------------------------------------

Hi Steve,

1. I was under the impression that you still needed the static build. Even 
otherwise don't you think its good to have a separate place for VS solutions so 
that the root directory does not get cluttered? Please let me know what you 
think. I think we should at least have a separate directory at the root level, 
not a deep directory tree as I have suggested, though.

2. Well importing symbols helps generate smaller and faster code (jums vs. 
indirect calls). I did not worry about it initially. On the other hand in order 
to support this, we need to have separate interfaces for each library we have 
(to be able to do both import/export). Anyways we should do it the proper way. 
I will do the changes and resubmit the patches.

3. I tried exporting classes themselves and gave it up in the middle. The 
problem in exporting class itself is that it is required to export all relevant 
base classes and all classes that are used for the definition of data members. 
And also there were issues due to not having default constructors for certain 
classes (Address was one of them if I remember right) and stuff like that. On 
the other hand exporing more than what is required is not necessary at the end 
of the day.

Please correct me if I am wrong. I will anyway resubmit patches for #2. Please 
let me know what you think of #1.

Thanks,
Danushka

> Dynamic Library Build on Windows (DLL)
> --------------------------------------
>
>                 Key: QPID-1673
>                 URL: https://issues.apache.org/jira/browse/QPID-1673
>             Project: Qpid
>          Issue Type: New Feature
>            Reporter: Danushka Menikkumbura
>            Assignee: Steve Huston
>         Attachments: create_dir_struct.bat, 
> QPID-1673-examples-solution.patch, QPID-1673-examples.patch, 
> QPID-1673-INSTALL-WINDOWS.patch, QPID-1673-qpid-solution.patch, 
> QPID-1673-rubygen.patch, QPID-1673-src-qpid-amqp_0_10.patch, 
> QPID-1673-src-qpid-client.patch, QPID-1673-src-qpid-framing.patch, 
> QPID-1673-src-qpid-log.patch, QPID-1673-src-qpid-management.patch, 
> QPID-1673-src-qpid-sys.patch, QPID-1673-src-qpid.patch, QPID-1673-src.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to