[
https://issues.apache.org/jira/browse/QPID-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734116#action_12734116
]
Pete MacKinnon commented on QPID-1918:
--------------------------------------
Hi Steve,
I will provide a future patch that will alllow for PipeHandle to have a local
_pipe as well as the select-friendly Socket approach.
I will revisit the ManagementAgentImpl.cpp code based on your suggestion but
there seems to be non-deterministic behavior between the connection and publish
logic which can sleep the publish thread for an inadvertently long time.
The uuid changes are actually more a less a revert to a previous version in
Qpid. It was the only way I could surmount some significant code-level
integration issues. I guess I could revisit this by trying to mitigate on the
Condor side but am not optimistic.
The HAVE_ flags for pid_t and ssize_t are artificial and would not currently
fall out of the Condor autotools step. They are specifically there for
code-level integration between Qpid and Condor. I raised
https://issues.apache.org/jira/browse/QPID-1951 to suggest we bury those Posix
decls in the portability layer to avoid this hack.
I have been working on the Cmake changes I need and I think it looks pretty
good. Once I have fixed some of the qmf-agent example QMF generation steps,
I'll submit.
In summary, I will attach an updated patch zip (hopefully soon).
\Pete
> Patches/files for Windows QMF plug-in support
> ---------------------------------------------
>
> Key: QPID-1918
> URL: https://issues.apache.org/jira/browse/QPID-1918
> Project: Qpid
> Issue Type: New Feature
> Components: Qpid Managment Framework
> Environment: Windows XP SP3, VC++ 9.0
> Reporter: Pete MacKinnon
> Assignee: Steve Huston
> Attachments: qpid-1918.zip
>
>
> Various files for the Windows QMF plug-in support in cpp, based off revision:
> 785848
> Need Static builds (release and debug) for correct runtime integration with
> Condor:
> src/broker.vcproj
> src/client.vcproj
> src/common.vcproj
> src/qmfagent.vcproj
> src/qmfconsole.vcproj
> src/qpid.sln
> src/qpidbroker.vcproj
> - Changed to provide compile flags required for header file integration of
> Posix types declared by both Qpid and Condor:
> src/qpid/sys/windows/IntegerTypes.h
> src/qpid/sys/windows/uuid.cpp
> src/qpid/sys/windows/uuid.h
> - Modified signature of PipeHandle ctor and fixed a Windows race condition in
> the processing loop:
> src/qpid/agent/ManagementAgentImpl.cpp
> - Refactored the pipe code so that Condor can get a true socket fd it can
> select on in daemon_core:
> src/qpid/sys/Pipehandle.h
> src/qpid/sys/posix/PipeHandle.cpp
> src/qpid/sys/windows/PipeHandle.cpp
> - Removed explicit dependency on Debug libs since we now have even more
> targets. Added Apache license:
> examples/qmf_agent.vcproj
> - Added Apache license:
> src/protocol_gen.mak
> examples/qmf-agent/example_gen.mak
> - Updated QMF Agent example README:
> examples/README
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
