gemmellr commented on code in PR #40: URL: https://github.com/apache/qpid-cpp/pull/40#discussion_r1168554340
########## Containerfile: ########## @@ -0,0 +1,60 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +FROM quay.io/centos/centos:stream9 as builder + +RUN dnf -y install epel-release 'dnf-command(config-manager)' +RUN dnf config-manager --set-enabled crb + +# I am referring to the CentOS7 package (.spec file in the src.rpm) to look up dependencies +# https://koji.fedoraproject.org/koji/buildinfo?buildID=1180279 +# TODO seemingly unavailable packages: +# xqilla-devel + +RUN dnf -y --setopt=install_weak_deps=0 --setopt=tsflags=nodocs install \ + rpm-build \ + gcc gcc-c++ make cmake \ + boost-devel boost-filesystem boost-program-options \ + xerces-c-devel \ + rdma-core-devel \ + libdb-devel libdb-cxx-devel libaio-devel \ + qpid-proton-c-devel \ + swig perl-devel python3-devel ruby-devel rubygem-rexml \ + libuuid-devel nss-devel nspr-devel nss-tools cyrus-sasl cyrus-sasl-lib cyrus-sasl-devel \ + wget tar patch findutils git pkgconfig + +# Workaround for latest release of qpid-python being incompatible with python 3 +WORKDIR /build +RUN git clone https://github.com/apache/qpid-python.git \ + && cd qpid-python \ + && python3 setup.py install Review Comment: Its fine to do this in a file aimed at e.g qpid-cpp developers building the latest code, but a 'normal' file aimed at regular users shouldnt be doing it as we need to point everyday users to released versions. This file looks to be of the former developer variety, but is more named and [not] documented as the normal user variety....it should be updated to be consistently one of the other. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
