[ 
https://issues.apache.org/jira/browse/QPID-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214095#comment-13214095
 ] 

Keith Wall commented on QPID-3325:
----------------------------------

Hi Robbie,

Two minor comments:

1) I think we should set the ShutdownHook's thread's name.   We seen the 
occasional deadlocks during shutdown in the past, and having the thread name in 
the thread dump might help diagnose if we ever have a re-occurence. 

2) I'm wondering if the responsibility for creating/registering/deregistering 
the shutdown hook would better sit with Broker rather than ApplicationRegistry. 
  (Maybe this would go beyond the scope of this Jira. What do you think)?

cheers Keith
                
> make the ApplicationRegistry unregister its shutdown hook when closed by 
> means other than the shutdown hook
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3325
>                 URL: https://issues.apache.org/jira/browse/QPID-3325
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Danushka Menikkumbura
>            Assignee: Keith Wall
>             Fix For: 0.15
>
>         Attachments: QPID-3325.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to