> On Jan. 22, 2013, 6:40 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/qpid/broker/Link.cpp, line 494 > > <https://reviews.apache.org/r/9055/diff/1/?file=251026#file251026line494> > > > > There appears to be no substitute for this test perhaps should be: > > if (state == STATE_CLOSING) return; > > > > Perhaps it doesn't matter except as a shortcut return.
Right - since the body only executes if state is operational or state is waiting, the extra check wasn't really necessary. But I'll change it to a switch statement to make that more clear. > On Jan. 22, 2013, 6:40 p.m., Andrew Stitcher wrote: > > /trunk/qpid/cpp/src/qpid/broker/Link.cpp, line 495 > > <https://reviews.apache.org/r/9055/diff/1/?file=251026#file251026line495> > > > > perhaps the entire "if (state ==" chain should be replaced with a > > "switch ... case" type of construct to make the state machine design more > > plain. Agreed - a switch will clarify the intent, I'll fix that. - Kenneth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9055/#review15574 ----------------------------------------------------------- On Jan. 22, 2013, 6:25 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9055/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2013, 6:25 p.m.) > > > Review request for qpid, Andrew Stitcher and Ted Ross. > > > Description > ------- > > Fixes a bug that prevents deletion of a Link when the corresponding > connection is not in the active state. > > > This addresses bug qpid-4546. > https://issues.apache.org/jira/browse/qpid-4546 > > > Diffs > ----- > > /trunk/qpid/cpp/src/qpid/broker/Link.h 1436517 > /trunk/qpid/cpp/src/qpid/broker/Link.cpp 1436517 > > Diff: https://reviews.apache.org/r/9055/diff/ > > > Testing > ------- > > Federation unit tests + tested deleting links that were disconnected and in > connection state. > > > Thanks, > > Kenneth Giusti > >
