Hi! > Yes, I did. > > Its a very simple one. > > > No, I totally disagree. > > There is *zero* documentation on what the changes attempt to accomplish. There is a one-liner above the code, maybe not the best english, but hey .... its not zero ;-)
> Besides that, there seem to be a large number of changes that are > (from the > viewpoint of an external person) totally gratuitous -- such as > changing data > types from List<...> to Collection<...>. This was required to being able to use a TreeSet instead of a list to avoid duplicate adding of jars. > As far as I understood your patch, you were planning to remove the > condition > about jars that had a META-INF/faces-conifg.xml file. Is that not the > acase? I didnt remove anything, I just *added* a functionality. Nothing changed to the previous behaviour. This patch and the discussion "[tiger] speedup of startup and extension to view annotation" are two completely different topics. Now to the patch: We heavily use the javax.faces.CONFIG_FILES context parameter to configure which faces-config.xml to load. As it is currently, shale-tiger will ignore our jars as we do not have a META-INF/faces-config.xml, instead we placed ours e.g. in content/APP/webconf/faces-config.xml Now by checking also the jars containing faces-config.xml configured by CONFIG_FILES we can make even such a configuration work with shale-tiger. Using your explicitResources() method will not increase or decrease speedup. This is not what the patch tried to address. I hope now its clear what I mean and what this patch do. Ciao, Mario
