On 9/29/06, Craig McClanahan <[EMAIL PROTECTED]> wrote:
On 9/29/06, Rahul Akolkar <[EMAIL PROTECTED]> wrote:
>
> The code review tool flags the instance variable data (the dialog
> data) being declared as an Object, in relevant places in both the
> basic and scxml impl. While we do document the fact that dialog data
> should be Serializable, we do not enforce that in code. Any downside
> to changing the type of 'data' to Serializable?
This particular one is a case that I don't think we should necessarily
enforce ... for example, if you run your app on a non-distributed version of
Tomcat, and disable the ability to save and restore session state across app
restarts, it will not matter that you've got non-serializable stuff here.
Changing the type to Serializable would disallow this use case.
<snip/>
More likely promote abuse of the marker interface, but I see the point.
-Rahul
Also getting flagged for missing serialVersionUIDs, don't see them
> elsewhere either (except in clay).
For things we explicitly declare as serializable, we'll definitely want
these.
-Rahul
>
Craig
