On 10/16/06, Craig McClanahan <[EMAIL PROTECTED]> wrote:
On 10/15/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
>
> All modified files in this commit should meet following criteria:
> 1) Have java, xml or html file extension
> and
> 2) Have an existing ASLv2 license header (that needs mods)
> and
> 3) Have the line endings set correctly in the repository
FWIW, we need to add *.jsp and *.properties files to this list. Also, I
don't think it should matter if there is an existing license header or not
... they might have been mistakenly omitted in the past.
<snip/>
Yup, should be covered in the coming attractions listed below.
I've tried to minimize the diffs, but that is not always possible (rather,
> feasible).
Not a problem ... thanks for taking this on! The only rule I try to follow
on stuff like this is to not mix unrelated changes in at the same time.
<snap/>
Indeed, if anyone finds anything unrelated, do yell ;-) Thats why any
files with missing props weren't included in this commit (they'll
cause larger diffs) ... I'll try to break those apart into SHALE-310
[1] commits first followed by SHALE-311 (this one) commits.
-Rahul
[1] https://issues.apache.org/struts/browse/SHALE-310
TODOs (might be next weekend, if left to me):
> * Pick-up stragglers (other extensions, files with missing props, files
> with missing headers)
> * Update checkstyle license header pattern
> * Update NOTICE
>
> SHALE-311
Craig
