jsedding commented on code in PR #16:
URL: 
https://github.com/apache/sling-org-apache-sling-auth-core/pull/16#discussion_r1719732667


##########
src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java:
##########
@@ -406,6 +406,9 @@ public static String getHttpAuth(final Config config) {
     @Override
     public boolean handleSecurity(HttpServletRequest request,
             HttpServletResponse response) {
+        if(request.getHeader("x-request-id") != null) {

Review Comment:
   In my opinion the value of `"x-request-id"` should be configurable. If 
blank, don't set the thread name.
   
   Also note that on Jetty the thread name includes the request method and 
path, with this change this information is lost, unless it is in the special 
header.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to