mreutegg commented on code in PR #6:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-impl/pull/6#discussion_r1753316448
##########
src/main/java/org/apache/sling/discovery/impl/common/heartbeat/HeartbeatHandler.java:
##########
@@ -63,11 +63,17 @@
* Local heartbeats are stored in the repository. Remote heartbeats are POSTs
to
* remote TopologyConnectorServlets.
*/
-@Component
-@Service(value = HeartbeatHandler.class)
-@Reference(referenceInterface=HttpService.class,
- cardinality=ReferenceCardinality.OPTIONAL_MULTIPLE,
- policy=ReferencePolicy.DYNAMIC)
+@Component(service = {HeartbeatHandler.class},
+ reference = {
+ @Reference(name = "HttpService",
+ service = HttpService.class,
+ cardinality = ReferenceCardinality.MULTIPLE,
+ policy = ReferencePolicy.DYNAMIC,
+ bind = "bindHttpService",
+ unbind = "unbindHttpService"
+ )
Review Comment:
Sounds good to me. I'll include that in a follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
