rombert commented on code in PR #4:
URL:
https://github.com/apache/sling-org-apache-sling-scripting-javascript/pull/4#discussion_r1851043608
##########
src/test/java/org/apache/sling/scripting/javascript/RepositoryScriptingTestBase.java:
##########
@@ -25,7 +25,6 @@
import org.apache.sling.commons.testing.jcr.RepositoryTestBase;
import org.apache.sling.scripting.javascript.internal.ScriptEngineHelper;
-
Review Comment:
Nit: please don't no whitespace only changes, it make it harder to track
history of file changes.
##########
pom.xml:
##########
@@ -142,16 +142,22 @@
<scope>provided</scope>
</dependency>
<!-- Testing -->
+ <dependency>
Review Comment:
Is this dependency needed? If I remove it locally your PR works just fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
