rombert commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-scripting-javascript/pull/10#issuecomment-2531796380
Thank you for the PR @scottyuancoc . Sorry for taking so long to review, I had to reaquaint myself with the topic. I agree this is an issue, although I have not seen any ill side effects in practice. Reading through https://www.cs.cornell.edu/courses/cs6120/2019fa/blog/double-checked-locking/ your solution would fall into the [Always-synchronised solution is slow](https://www.cs.cornell.edu/courses/cs6120/2019fa/blog/double-checked-locking/#always-synchronized-solution-is-slow) category so I would not merge it as-is without understanding the performance implications. I know @joerghoh has been looking into performance-related topics recently, maybe he has some ideas about the impact? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
