anchela commented on code in PR #60:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-repoinit/pull/60#discussion_r1963557678
##########
src/main/java/org/apache/sling/jcr/repoinit/impl/RepositoryInitializer.java:
##########
@@ -115,6 +118,8 @@ public void processRepository(SlingRepository repo) throws
RepositoryException {
throw new RepoInitException("Error executing repoinit
from " + reference, e);
}
}
+ Duration duration = Duration.between(start, Instant.now());
Review Comment:
i would move it out of the try-finally block and record timing also in case
of failure.
if possible include a hint if it failed or succeeded
##########
src/main/java/org/apache/sling/jcr/repoinit/impl/RepositoryInitializerFactory.java:
##########
@@ -163,6 +166,8 @@ public void processRepository(final SlingRepository repo)
throws Exception {
scriptIndex++;
}
}
+ Duration duration = Duration.between(start, Instant.now());
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
