On Monday, March 10, 2025 10:19:50 AM Central European Standard Time Carsten Ziegeler wrote: > Hi Oli,
Hi Carsten, > On 10.03.2025 10:00, Oliver Lietz wrote: > > On Monday, March 10, 2025 9:40:28 AM Central European Standard Time > > Carsten > > > > Ziegeler wrote: > >> Right, so how about we create a 4.1 release with TinyBundles 4.0? I > >> think that might already solve the issues. > > > > Can you confirm issues are resolved with Testing PaxExam revision f0b63e8? > > > > https://github.com/apache/sling-org-apache-sling-testing-paxexam/tree/ > > f0b63e86ed9519559031bfb2de7b3ec189bfcdd1 > > it mostly works with that. I had to add bnd to the test maven > dependencies in servlets resolver (fyi, for 5.0.0-SNAPSHOT I had to do > the same). See > https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/b1 > b88dcdf799ce5a333b0453ada486370b4cc7be > > And when building Sling Testing Paxeaxm all tests fail with > "java.lang.NoClassDefFoundError: > org/ops4j/pax/tinybundles/core/TinyBundles". I ignored the tests. I > assume we should fix those as well? Please try again with branch 4.1 (Exam 4.14.0 and TinyBundles 4.0.0): https://github.com/apache/sling-org-apache-sling-testing-paxexam/tree/4.1 > > I will try to free up some time to prepare the release. > > That would be great! New 4.1.0 release in Jira: https://issues.apache.org/jira/issues/? jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Testing%20PaxExam%204.1.0%22 O. > Thanks > Carsten > > > O. > > > >> Regards > >> Carsten > >> > >> On 10.03.2025 09:05, Oliver Lietz wrote: > >>> On Monday, March 10, 2025 7:34:08 AM Central European Standard Time > >>> Carsten > >>> > >>> Ziegeler wrote: > >>>> Hi, > >>> > >>> Hi Carsten, > >>> > >>>> I created a test branch for servlets resolver where I just bumped to > >>>> Java17, updated Sling Testing PaxExams to 4.0 and PaxExams to the > >>>> latest. > >>>> > >>>> https://github.com/apache/sling-org-apache-sling-servlets-resolver/tree > >>>> /j > >>>> ava 17 > >>>> > >>>> This fails with > >>>> "java.lang.NoClassDefFoundError: org/ops4j/pax/tinybundles/TinyBundles" > >>> > >>> That is expected. 4.0 requires TinyBundles 3.0 and Exam 4.14 requires > >>> TinyBundles 4.0. > >>> > >>> You may be able to work around by providing both TinyBundles 3.0 and 4.0 > >>> if > >>> needed (and Maven doesn't come in your way). > >>> > >>> HTH, > >>> O. > >>> > >>>> Regards > >>>> Carsten > >>>> > >>>> On 09.03.2025 20:58, Carsten Ziegeler wrote: > >>>>> Hi Oli, > >>>>> > >>>>> thats good news that 4.0 should work with Java 17+. I don't remember > >>>>> the > >>>>> details, but when I tried building scripting.core and > >>>>> servlets.resolver > >>>>> with Java 17 as base and changed to testing paxeaxm 4.0 it didn't > >>>>> work. > >>>>> > >>>>> I think if we can make those two bundles build with Java 17 then we > >>>>> should have fixed the issue - it could also be that I simply did > >>>>> something completely wrong :) > >>>>> > >>>>> I'm also fine with a 4.1 release in case something needs to be fixed. > >>>>> > >>>>> Regards > >>>>> Carsten > >>>>> > >>>>> On 09.03.2025 19:12, Oliver Lietz wrote: > >>>>>> On Sunday, March 9, 2025 11:35:51 AM Central European Standard Time > >>>>>> Carsten > >>>>>> > >>>>>> Ziegeler wrote: > >>>>>>> Hi, > >>>>>> > >>>>>> Hi Carsten, > >>>>>> > >>>>>>> while I worked on adding jakarta servlet support to our codebase I > >>>>>>> had > >>>>>>> to update to Java 17 (as mentioned in those threads). > >>>>>>> Our released version of Sling Testing PaxExam 4.x does not support > >>>>>>> Java > >>>>>>> 17 so I had to switch to the unreleased 5.0.0 version - so far so > >>>>>>> good. > >>>>>> > >>>>>> Sling Testing PaxExam 4.0 works with Java 17 (and 21) in general. > >>>>>> You can build the latest revision of Sling Commons Crypto before I > >>>>>> changed to > >>>>>> 5.0.0-SNAPSHOT with Java 17 without any errors: > >>>>>> > >>>>>> https://github.com/apache/sling-org-apache-sling-commons-crypto/tree/ > >>>>>> 7bd8d8d78ebd102f8afefb4757be719b9bcd8a32 > >>>>>> > >>>>>>> However, that version has removed all sling options as part of > >>>>>>> https://issues.apache.org/jira/browse/SLING-12577 - which makes it a > >>>>>>> very complicated and time consuming process if you just want to > >>>>>>> update > >>>>>>> your pax exam tests to Java 17 (without any further changes). I > >>>>>>> ended > >>>>>>> up > >>>>>>> copying those options from the 4.x release into each and every > >>>>>>> module > >>>>>>> (and stripped it down a little bit). > >>>>>> > >>>>>> Newer Java versions become problematic due to outdated bundles (incl. > >>>>>> bnd and > >>>>>> therefore TinyBundles). > >>>>>> You have to compile your set of bundles and configurations sooner or > >>>>>> later > >>>>>> again yourself. > >>>>>> > >>>>>>> While I understand the reasoning behind this change, how about > >>>>>>> making > >>>>>>> a > >>>>>>> 5.0.0 release with them back in - with that release we make it > >>>>>>> pretty > >>>>>>> easy to update our code base to Java 17. And then a 6.0.0 release > >>>>>>> where > >>>>>>> these options are dropped. > >>>>>>> > >>>>>>> WDYT? > >>>>>> > >>>>>> What exactly is not working? > >>>>>> Can we fix it with a minor update which could go into a 4.1 release? > >>>>>> > >>>>>> O. > >>>>>> > >>>>>>> Regards > >>>>>>> Carsten
