rombert commented on PR #23:
URL:
https://github.com/apache/sling-org-apache-sling-commons-log/pull/23#issuecomment-2801474436
Oh, those packages are re-imported, so no issue here. Trying to integrate
this in the Starter I see that various bundles would fail to resolve if I
remove all traces of slf4j because of the missing 'bridges'
```
[ERROR] [bundle-packages] org.apache.pdfbox:pdfbox:2.0.33: Bundle is
importing package org.apache.commons.logging with start order 10 but no bundle
is exporting these for that start order.
[ERROR] [bundle-packages] org.apache.httpcomponents:httpclient-osgi:4.5.14:
Bundle is importing package org.apache.commons.logging with start order 15 but
no bundle is exporting these for that start order.
[ERROR] [bundle-packages] org.apache.pdfbox:fontbox:2.0.33: Bundle is
importing package org.apache.commons.logging with start order 10 but no bundle
is exporting these for that start order.
[ERROR] [bundle-packages] org.apache.sling:org.apache.sling.xss:2.4.6:
Bundle is importing packages [org.apache.commons.logging, org.apache.log4j]
with start order 20 but no bundle is exporting these for that start order.
```
Of course, we can add back required bundles to the starter
- `org.slf4j:jcl-over-slf4j:${slf4j.version}`
- `org.slf4j:log4j-over-slf4j:${slf4j.version`
But then we'd end up in a situation where we partially embed and partially
deploy slf4j. Should we instead embed all needed slf4j jars in the commons.log
bundle?
(and BTW when running the Starter ITs all the logging output goes to the
console, but that's something for later)
```patch
diff --git a/src/main/features/boot.json b/src/main/features/boot.json
index ce0d02e..bcc4584 100644
--- a/src/main/features/boot.json
+++ b/src/main/features/boot.json
@@ -69,7 +69,7 @@
"start-order":"1"
},
{
- "id":"org.apache.sling:org.apache.sling.commons.log:5.5.0",
+
"id":"org.apache.sling:org.apache.sling.commons.log:jar:all:6.0.0-SNAPSHOT",
"start-order":"1"
},
{
@@ -152,10 +152,6 @@
"id":"org.slf4j:log4j-over-slf4j:${slf4j.version}",
"start-order":"1"
},
- {
- "id":"org.slf4j:slf4j-api:${slf4j.version}",
- "start-order":"1"
- },
{
"id":"org.apache.felix:org.apache.felix.scr:2.2.12",
"start-order":"1"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
