[
https://issues.apache.org/jira/browse/SLING-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946644#comment-17946644
]
Joerg Hoh edited comment on SLING-12757 at 4/23/25 7:38 AM:
------------------------------------------------------------
My personal preference is 1, because the code throws exception in these cases
since a long time. Plus I don't know what value should be returned in case such
an exception is caught.
was (Author: joerghoh):
My personal option is 1, because the code throws exception in these cases since
a long time. Plus I don't know what value should be returned in case such an
exception is caught.
> AbstractResource.getName() can throw exceptions
> -----------------------------------------------
>
> Key: SLING-12757
> URL: https://issues.apache.org/jira/browse/SLING-12757
> Project: Sling
> Issue Type: Task
> Components: API
> Affects Versions: API 2.27.6
> Reporter: Joerg Hoh
> Priority: Major
>
> {{AbstractResource.getName()}} can throw both a NPE and an
> IllegalArgumentException, because these can thrown by
> {{ResourceUtil.getName()}}, although this is not documented.
> We have 2 options:
> # keep the existing implementation and adjust the API doc, that it can throw
> these exceptions.
> # stick to the existing API doc and catch&log these 2 exceptions. This leaves
> the question what to return in this case.
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
