cziegeler commented on code in PR #60:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/60#discussion_r2121730547
##########
src/main/java/org/apache/sling/api/resource/SyntheticResource.java:
##########
@@ -43,8 +43,9 @@ public class SyntheticResource extends AbstractResource {
* Creates a synthetic resource with the given <code>path</code> and
* <code>resourceType</code>.
* @param resourceResolver The resource resolver
- * @param path The resource path
+ * @param path The absolute resource path including the name. Make sure
that each segment of the path only contains valid characters in Sling API
resource names.
Review Comment:
Throwing an exception for cases that previously did not is a breaking change
- and for sure will break existing code; regardless of how strange the current
usage pattern is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
