rombert commented on code in PR #59:
URL:
https://github.com/apache/sling-org-apache-sling-api/pull/59#discussion_r2123747211
##########
src/main/java/org/apache/sling/api/resource/ModifiableValueMap.java:
##########
@@ -59,11 +59,12 @@
* </ul>
* <p>
*
- * A modifiable value map should value {@link
ResourceResolver#PROPERTY_RESOURCE_TYPE}
- * to set the resource type of a resource.
+ * A modifiable value map should value {@code
ResourceResolver#PROPERTY_RESOURCE_TYPE}
Review Comment:
If you're touching this anway, maybe you can clarify this statement, I can't
parse it
> A modifiable value map should value {@code
ResourceResolver#PROPERTY_RESOURCE_TYPE}
##########
src/main/java/org/apache/sling/api/resource/ResourceResolver.java:
##########
@@ -769,10 +776,12 @@ public interface ResourceResolver extends Adaptable,
Closeable {
/**
* Add a child resource to the given parent resource.
* The changes are transient and require a call to {@link #commit()} for
persisting.
+ * The mandatory resource type is either determined by the property
{@value ResourceResolver#PROPERTY_RESOURCE_TYPE} or set by the underlying
resource provider to some value.
+ * The optional resource super type is determined by the property {@value
ResourceResolver#PROPERTY_RESOURCE_SUPER_TYPE}.
*
* @param parent The parent resource
* @param name The name of the child resource - this is a plain name,
not a path!
- * @param properties Optional properties for the resource
+ * @param properties Optional properties for the resource (may be
<code>null</code>).
Review Comment:
Would it make sense to annotate the parameter with `@Nullable` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
