[
https://issues.apache.org/jira/browse/SLING-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315833#comment-14315833
]
Robert Munteanu commented on SLING-4399:
----------------------------------------
[~asanso] - thanks for catching this! Fix looks good to me. Something which
looks simpler to me is pasted below, but I don't have a strong preference for it
{code:java}diff --git
a/bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java
b/bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java
index 1b62c58..d5e4aa0 100644
---
a/bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java
+++
b/bundles/auth/core/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticator.java
@@ -540,6 +540,10 @@ public class SlingAuthenticator implements Authenticator,
+ holder + ", access forbidden", ioe);
done = true;
}
+
+ if ( done ) {
+ break;
+ }
}
}
}
{code}
> Regression in the SlingAuthenticator
> ------------------------------------
>
> Key: SLING-4399
> URL: https://issues.apache.org/jira/browse/SLING-4399
> Project: Sling
> Issue Type: Bug
> Components: Authentication
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
>
> SLING-3936 introduced a regression.
> Obseving the diff
> {code}
> - for (int i = 0; !done && i < holderList.size(); i++) {
> - final AbstractAuthenticationHandlerHolder holder = holderList.get(i);
> + for (AbstractAuthenticationHandlerHolder holder : holderList) {
> {code}
> it is clear that {{!done}} has been lost in translation
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
