[ 
https://issues.apache.org/jira/browse/SLING-4788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639956#comment-14639956
 ] 

Carsten Ziegeler commented on SLING-4788:
-----------------------------------------

I think the inventory api is there for these things, so we should use it. There 
are a couple of ways to fix the ordering problem:
- put the inventory into a different bundle
- make the imports optional/dynamic and register the service as a service 
factory. this allows to register the printer even without the inventory bundle 
being available and once it's there the printer gets picked up

> SlingConfigurationPrinter should use mode aware and only stream the full logs 
> in the zip version and avoid duplicate information
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-4788
>                 URL: https://issues.apache.org/jira/browse/SLING-4788
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons
>    Affects Versions: Commons Log 4.0.0, Commons Log 4.0.2
>            Reporter: Thierry Ygé
>            Assignee: Chetan Mehrotra
>
> Currently the SlingConfigurationPrinter is not mode aware, it produce a log 
> files.txt that contains / combine all the logs in one, which is an issue when 
> there are really a lot of logs and large.
> Also the zip version will contains then both output once combined and once as 
> log attached.
> To improve this it would be easier to use the mode aware interface 
> ModeAwareConfigurationPrinter, and define different output style. 
> In text mode it should only list the log files available, a tail of the last 
> n lines could be added.
> In zip mode, it should then attache the logs, eventually an option to only 
> add logs that are n days old or n lines , to avoid too large zip files which 
> can also sometime be a problem when trying to analyze a recent issue.
> I did a quick test based on the current release and that is possible to 
> achieve at least the mode awareness.
> [~cziegeler] Can you check if that can be done for a future release of common 
> logs ?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to