[
https://issues.apache.org/jira/browse/SLING-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327191#comment-15327191
]
ASF GitHub Bot commented on SLING-5781:
---------------------------------------
GitHub user anagarwa opened a pull request:
https://github.com/apache/sling/pull/146
SLING-5781 [i18n] generating locale from a string is incorrect
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anagarwa/sling SLING-5781
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #146
----
commit 28a74f458219e5c5f1db0714969925ccbe8fc6a8
Author: Ankit Agarwal <[email protected]>
Date: 2016-06-13T11:34:13Z
SLING-5781 [i18n] generating locale from a string is incorrect
----
> [i18n] generating locale from a string is incorrect
> ---------------------------------------------------
>
> Key: SLING-5781
> URL: https://issues.apache.org/jira/browse/SLING-5781
> Project: Sling
> Issue Type: Bug
> Components: Extensions
> Affects Versions: i18n 2.4.6
> Reporter: Ankit Agarwal
>
> As per sling document here
> https://sling.apache.org/documentation/bundles/internationalization-support-i18n.html
> parts of locale string are separated by hyphen ("-") like de-DE-MAC but in
> JCRResourceBundleProvider while extracting locale from a String we are
> separating parts with underscore ("_") as done here
> https://github.com/apache/sling/blob/trunk/bundles/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java#L586
> Should this be change to separate string on "-" basis ?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
