On Fri, 2016-06-10 at 20:21 +0200, Oliver Lietz wrote: > On Friday 10 June 2016 14:51:43 Robert Munteanu wrote: > > Hi, > > Hi Robert, > > > We have a couple of scripts in the root folder: > > > > - modules.py > > - update_dependencies.sh > > - check_release_matches_tag.sh > - check_staged_release.sh
true, but I think those two are pretty self-explanatory, at least to me. > > > > > As they are not frequently used, I suggest we move them to > > 'tooling/release' or maybe 'tooling/scm' if appropriate. > > > > Also, I'm not sure how to use update_dependencies.sh, there are no > > docs > > for it and invoking it directly ( Linux, bash 4.3, sed 4.2.2 ) > > errors > > out with > > > > sed: can't read > > s/<oak.version>1.3.16<\/oak.version>/<oak.version>1.4.0<\/oak.versi > > on>/ > > 1: No such file or directory > > sed: can't read > > s/<oak.version>1.3.16<\/oak.version>/<oak.version>1.4.0<\/oak.versi > > on>/ > > 1: No such file or directory > > > > (and many similar lines). > > > > Opinions? > > modules.py: > > --------8<----------------------------------------------------------- > -- > # simple script to find projects (modules) and print their artifact > ids > # could help when moving from Subversion to Git > (https://issues.apache.org/jira/browse/SLING-3987) > > [...] > > def usage(): > print 'usage:', sys.argv[0], 'projects root, e.g. trunk or > whiteboard' > --------8<----------------------------------------------------------- > -- > That was in my opinion pretty clear, but could be moved under tools/ since it's not frequently used. > update_dependencies.sh: > > --------8<----------------------------------------------------------- > -- > # sed (BSD only) commands to change versions > # TODO make GNU compatible > > [...] > > # Oak > OAK_VERSION_CURRENT=1.3.16 > OAK_VERSION_NEW=1.4.0 > --------8<----------------------------------------------------------- > -- > > *_VERSION_CURRENT: the current version of dependencies > *_VERSION_NEW: the new version of dependencies > > Not sure what is not obvious here. As I'm the only one using this > scripts I > will remove them from Subversion. Well, I tried to use the update_dependencies.sh script but failed. So at least a little explanation would be great. But instead I updated the version by hand :-) Removing may be a little drastic, I also have stuff that was probably only used by myself for the launchpad releases, but I kept being optimistic and added them to SVN. Robert > > Regards, > O. > > > > > Robert >
