[ 
https://issues.apache.org/jira/browse/SLING-6110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15554585#comment-15554585
 ] 

ASF GitHub Bot commented on SLING-6110:
---------------------------------------

GitHub user marcel-j opened a pull request:

    https://github.com/apache/sling/pull/178

    SLING-6110: use the proper bundleContext in the ServerSideTeleporter …

    …to retrieve the correct bundle headers

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/marcel-j/sling trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sling/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit c400ed4291090da2fb522692a1837265d991db2a
Author: Marcel Jolk <[email protected]>
Date:   2016-10-07T09:00:10Z

    SLING-6110: use the proper bundleContext in the ServerSideTeleporter to 
retrieve the correct bundle headers

----


> ServerSideTeleporter can't read the bundle header 
> Sling-Test-WaitForService-Timeout
> -----------------------------------------------------------------------------------
>
>                 Key: SLING-6110
>                 URL: https://issues.apache.org/jira/browse/SLING-6110
>             Project: Sling
>          Issue Type: Bug
>          Components: Testing
>    Affects Versions: JUnit Tests Teleporter 1.0.8, JUnit Core 1.0.18
>            Reporter: Marcel Jolk
>             Fix For: JUnit Core 1.0.20
>
>
> The _Sling-Test-WaitForService-Timeout_ bundle header is not properly read by 
> the {{ServerSideTeleporter}}. The method {{getService()}} reads the bundle 
> header using the {{BundleContext}} 
> ({{bundleContext.getBundle().getHeaders()}}). This {{BundleContext}} is set 
> in the {{Activator}} class on start of the bundle 
> {{org.apache.sling.junit.core}}. Therefore {{bundleContext.getBundle()}} 
> resolves to the bundle {{org.apache.sling.junit.core}}. This bundle does not 
> have the proper headers. Instead the bundle headers of the bundle, which is 
> created in the {{ClientSideTeleporter}}, including the class under test, 
> should be used. Thus its {{BundleContext}} is needed.
> I already made the required code changes using {{FrameWorkUtil}} to retrieve 
> the {{BundleContext}} for the class under test. I'll create a pull request, 
> which resolves this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to