[
https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470983#comment-15470983
]
ASF GitHub Bot commented on THRIFT-3828:
----------------------------------------
GitHub user jmesmon opened a pull request:
https://github.com/apache/thrift/pull/1082
THRIFT-3828 In cmake avoid use of both quoted paths and SYSTEM with
include_directories()
This allows us to avoid issues where there are no paths to be added to
the include path (include_directories() errors when given an empty
string).
Specifically, gcc-6 requires that libraries stop passing paths like
'/usr/include' (or they will get libstdc++ build errors), so these paths
will be empty more often in the future.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesmon/thrift fix-includes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1082.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1082
----
commit b0c5e8c5c123fea57bd2780e66e0b25ac392ffe1
Author: Cody P Schafer <[email protected]>
Date: 2016-05-16T19:21:10Z
THRIFT-3828 In cmake avoid use of both quoted paths and SYSTEM with
include_directories()
This allows us to avoid issues where there are no paths to be added to
the include path (include_directories() errors when given an empty
string).
Specifically, gcc-6 requires that libraries stop passing paths like
'/usr/include' (or they will get libstdc++ build errors), so these paths
will be empty more often in the future.
----
> cmake fails when Boost_INCLUDE_DIRS (and other variables passed to
> include_directories()) is empty
> ---------------------------------------------------------------------------------------------------
>
> Key: THRIFT-3828
> URL: https://issues.apache.org/jira/browse/THRIFT-3828
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Reporter: Cody Schafer
> Priority: Minor
> Attachments:
> 0001-cmake-avoid-use-of-both-quoted-paths-and-SYSTEM-with.patch
>
>
> This is due to the current quoting of those variables when passed to
> `include_directories()`. These variables may (and soon will, see below) be
> empty in the case where the include directory is a system include path that
> is implicitly included.
> I ran into this issue when trying to build thrift using gcc-6. gcc-6 doesn't
> work with includes that are part of the platform/system include path (see
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129 for one mention). To
> resolve this, `FindBoost.cmake` will be adjusted to avoid adding those types
> of directories to Boost_INCLUDE_DIRS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
