[
https://issues.apache.org/jira/browse/THRIFT-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552468#comment-15552468
]
ASF GitHub Bot commented on THRIFT-3942:
----------------------------------------
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1108#discussion_r82233502
--- Diff: lib/cpp/test/TSSLSocketInterruptTest.cpp ---
@@ -57,12 +54,6 @@ struct GlobalFixtureSSL
BOOST_TEST_MESSAGE(boost::format("argv[%1%] = \"%2%\"") % i %
master_test_suite().argv[i]);
}
-#ifdef __linux__
- // OpenSSL calls send() without MSG_NOSIGPIPE so writing to a socket
that has
- // disconnected can cause a SIGPIPE signal...
- signal(SIGPIPE, SIG_IGN);
--- End diff --
This is part of the test code for setup/teardown, so it should not affect
applications, but I've reverted my change here.
> TSSLSocket does not honor send and receive timeouts
> ---------------------------------------------------
>
> Key: THRIFT-3942
> URL: https://issues.apache.org/jira/browse/THRIFT-3942
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.3
> Reporter: Ted Wang
> Assignee: Ted Wang
>
> TSocket respects send and receive timeout, but TSSLSocket does not. This is
> because it always pass -1 to THRIFT_POLL in waitForEvent:
> https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/transport/TSSLSocket.cpp#L645
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
